-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow license and creator edit keyboard access #18936
base: dev
Are you sure you want to change the base?
Workflow license and creator edit keyboard access #18936
Conversation
Can you also remove the save/cancel buttons ? We don't do that anywhere else in the editor |
@mvdbeek The creator form is using it: |
oh those buttons are much nicer click targets than the absolutely miniscule 'save' icon that's currently used. Would be very happy to have those larger targets for my poor mouse aim (the reason I use the keyboard to start with) |
Yeah, I think removing those save button would be great. |
+1 to removing them and saving consistent with other workflow changes. |
Thank you all for the comments. So I will remove the buttons and show only the licence selector on the editor. |
…add error alert, improve button controls and make them accessible via keyboard
…lity Updated the `LicenseSelector` component to enhance user experience by replace a `Multiselect` form `vue-multiselect` dropdown and simplifying the license handling steps and logic.
9925cc1
to
024bf21
Compare
Closes #18915. This PR improves the
LicenseSelector
andCreatorEditor
ui and makes them keyboard accessible. It migratesLicenseSelector
to composition API and typescript, uses GalaxyAPI to fetch license options, and uses theMultiSelect
component, simplifying the license handling steps.Workflow.license.and.creator.edit.keyboard.access.mov
How to test the changes?
(Select all options that apply)
License